Guard CuPy CTK extra for wheel metadata#1469
Open
bdice wants to merge 3 commits into
Open
Conversation
bdice
added
non-breaking
📝 WalkthroughWalkthrough
ChangesCuPy dependency matrix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5-15 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@dependencies.yaml`:
- Around line 528-539: The new pyproject matrix entries in the dependency
generation config are still overlapping with the existing [ctk] pyproject rows,
so the disabled-wheel case can continue matching cupy-cuda12x/13x[ctk]. Update
the pyproject matrix rules so the [ctk] rows are explicitly gated on
use_cuda_wheels: "true", and ensure the false case only matches the non-[ctk]
packages in the same dependency definition.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: a6a285ea-ad7a-40e8-a840-356369162683
📒 Files selected for processing (1)
dependencies.yaml
jameslamb
approved these changes
Jun 26, 2026
CI Test Summary✅ All 31 test job(s) passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#279
This keeps
cupy-cuda12x[ctk]andcupy-cuda13x[ctk]in wheel metadata when CUDA wheels are used, while generating barecupy-cuda12xandcupy-cuda13xmetadata whenuse_cuda_wheels=false.